<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - document IDs in trailer dict should be printed as hex strings" href="https://bugs.freedesktop.org/show_bug.cgi?id=97068#c18">Comment # 18</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - document IDs in trailer dict should be printed as hex strings" href="https://bugs.freedesktop.org/show_bug.cgi?id=97068">bug 97068</a> from <a class="email" href="mailto:jakubalba@gmail.com" title="Jakub Alba <jakubalba@gmail.com>"> Jakub Alba</a> <pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=97068#c17">comment #17</a>) > (In reply to Jakub Alba from <a href="show_bug.cgi?id=97068#c13">comment #13</a>) > > Created <a href="attachment.cgi?id=125498" name="attach_125498" title="[PATCH 1/2] introduced hex string as a new Object type and used it for file identifier">attachment 125498</a> <a href="attachment.cgi?id=125498&action=edit" title="[PATCH 1/2] introduced hex string as a new Object type and used it for file identifier">[details]</a> <a href='page.cgi?id=splinter.html&bug=97068&attachment=125498'>[review]</a> [review] [review] > > [PATCH 1/2] introduced hex string as a new Object type and used it for file > > identifier > > > > (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=97068#c12">comment #12</a>) > > > After having a look at the first patch, i was wondering if we really need > > > the "hex" variable in the union, can't we just use string? > > > > I added it, because I'd had some problems when writing this code, but now, > > when I checked once again, it seems that using string is perfectly OK. > > So can you please update the patches to use string? They do use string (the variable in the union). They just still introduce a new enum element just to carry the information if the string is a hex string. Or am I missing something?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>