<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Call ansi functions directly, to be able to compile with different -DUNICODE variants" href="https://bugs.freedesktop.org/show_bug.cgi?id=100312#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Call ansi functions directly, to be able to compile with different -DUNICODE variants" href="https://bugs.freedesktop.org/show_bug.cgi?id=100312">bug 100312</a> from <a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> Adrian Johnson</a> <pre>(In reply to Christoph Cullmann from <a href="show_bug.cgi?id=100312#c1">comment #1</a>) > Created <a href="attachment.cgi?id=130371" name="attach_130371" title="Updated patch, missed some functions, compiles no in our CI">attachment 130371</a> <a href="attachment.cgi?id=130371&action=edit" title="Updated patch, missed some functions, compiles no in our CI">[details]</a> <a href='page.cgi?id=splinter.html&bug=100312&attachment=130371'>[review]</a> [review] > Updated patch, missed some functions, compiles no in our CI I agree with explicitly specifying the A or W variant for all win32 API that takes strings. The win32 code in gfile.cc should be updated to accept UTF8 strings and convert to UTF16 and call the W variant to ensure full unicode support. This would avoid all the win32 specific code in other locations eg PDFDoc.cc line 173. We should consistently use UTF8 in poppler code and just do the conversion to wchar_t in the win32 portability code.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>