<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99271#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99271">bug 99271</a>
from <span class="vcard"><a class="email" href="mailto:oliver.sander@tu-dresden.de" title="oliver.sander@tu-dresden.de">oliver.sander@tu-dresden.de</a>
</span></b>
<pre>Thanks for the new patch. Three of my issues remain. Albert, what do you say?
+ if (gstr.getLength() >= end && gstr.getChar(start) == '<' &&
gstr.getChar(end-1) == '>')
+ {
+ ++start;
+ --end;
+ int len = end-start;
'end' and 'start' are of type Goffset. So shouldn't 'len' be Goffset, too?
+const char *SignatureHandler::getHashAlgorithmName()
+{
+ if (hash_context != nullptr && hash_context->hashobj != nullptr)
+ {
+ switch(hash_context->hashobj->type)
+ {
+ case HASH_AlgMD2:
+ return "MD2";
[snip]
+ case HASH_AlgSHA224:
+ return "SHA-224";
+ default:
+ return nullptr;
Should there be a warning when an unsupported hash algorithm is found?
(Albert, you did say that this was an issue for you, but what is the proposed
solution?)
struct SignatureValidationInfoPrivate {
- SignatureValidationInfo::SignatureStatus signature_status;
- SignatureValidationInfo::CertificateStatus certificate_status;
-
- QString signer_name;
- time_t signing_time;
+ SignatureValidationInfo::SignatureStatus signature_status;
+ SignatureValidationInfo::CertificateStatus certificate_status;
Tabs replaced by spaces here. Intentional?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>