<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Sign PDF with digital signature"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99416#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Sign PDF with digital signature"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99416">bug 99416</a>
from <span class="vcard"><a class="email" href="mailto:huj@froreich-bioscientia.de" title="Hans-Ulrich Jüttner <huj@froreich-bioscientia.de>"> <span class="fn">Hans-Ulrich Jüttner</span></a>
</span></b>
<pre>(In reply to oliver.sander from <a href="show_bug.cgi?id=99416#c7">comment #7</a>)
<span class="quote">> I tried the patch, but it doesn't apply cleanly. I suppose that's because
> it depends on some incarnation of the patches in
>
> <a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="show_bug.cgi?id=99271">https://bugs.freedesktop.org/show_bug.cgi?id=99271</a>
>
> So getting those in would help with reviewing here.</span >
You are right, this patch depends heavily on the patch #99271.
Unfortunately it started off from that patch as it was in <a href="show_bug.cgi?id=99416#c7">comment 7</a>
before rework after your review on #99271. That results in not applying
cleanly now for this patch. There seems to be hope that we get patch
#99271 in some time soon. Therefore I suggest that I'll revise this
patch then on a clean basis with attention to your comments below.
[snip]
<span class="quote">> @@ -535,7 +591,7 @@ GooString* FormWidgetSignature::getCheckedSignature()
> break;
> }
> }
> - if (sigLen > 0 && 2*(sigLen+lenBytes) < len-4)
> + if (sigLen > 0 && 2*(sigLen+lenBytes) <= len-4)
>
>
> This smells like a separate bugfix. Should this go into a separate patch?
> </span >
Yes this should go into patch #99271 as getCheckedSignature() was added there.
[snip]
Thank you for the review!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>