<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:huj@froreich-bioscientia.de" title="Hans-Ulrich Jüttner <huj@froreich-bioscientia.de>"> <span class="fn">Hans-Ulrich Jüttner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99271">bug 99271</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #131973 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99271#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - make it possible to extract digital signature data (also in pdfsig)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99271">bug 99271</a>
from <span class="vcard"><a class="email" href="mailto:huj@froreich-bioscientia.de" title="Hans-Ulrich Jüttner <huj@froreich-bioscientia.de>"> <span class="fn">Hans-Ulrich Jüttner</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=132053" name="attach_132053" title="Patch fixing this bug and adding support for specification of a validation time">attachment 132053</a> <a href="attachment.cgi?id=132053&action=edit" title="Patch fixing this bug and adding support for specification of a validation time">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=99271&attachment=132053'>[review]</a>
Patch fixing this bug and adding support for specification of a validation time
I changed the types of 'start' and 'end' to int as they are put into
GooString::getChar() which takes an int and would anyway produce an integer
overflow for values >= 2GB. I think that should fix the complaint about the
differing type of 'len'.
I looked for a solution of presenting a warning on invalid hash algorithm types
in method SignatureHandler::getHashAlgorithmName(). I found out that code using
poppler may call setErrorCallback() to prevent method error() from printing to
the console. So I think it's fine to use method error() for presenting the
warning.
Although I dislike tabs in code I now use them in the declaration of
struct SignatureValidationInfoPrivate in order to not replace the tabs
which were already there.
I also added a bugfix from the patch #99416 to method
FormWidgetSignature::getCheckedSignature() here:
- if (sigLen > 0 && 2*(sigLen+lenBytes) < len-4)
+ if (sigLen > 0 && 2*(sigLen+lenBytes) <= len-4)
As Oliver Sander pointed out in a review to that patch, it does not belong
there. It definitely belongs here.
I hope you will be satisfied with the new patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>