<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - page.text() does not take page orientation into account" href="https://bugs.freedesktop.org/show_bug.cgi?id=94517#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - page.text() does not take page orientation into account" href="https://bugs.freedesktop.org/show_bug.cgi?id=94517">bug 94517</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>(In reply to jalanpalmer from <a href="show_bug.cgi?id=94517#c9">comment #9</a>) > (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=94517#c8">comment #8</a>) > > I'm a bit hesitant about that patch as since it would break the people that > > are passing the coordinates to make it work like it works right now. > > That's a good point. Maybe best to keep it how it is to avoid breaking any > users. > > > so maybe the only thing we need to do is actually do a switch of coords in > > the > > if (r.is_empty()) { > > branch? > > That would fix > p->text() > but some users may also use > p->text(p->page_rect()) > and then they won't get all the text. > > Quite a predicament! But the documentation doesn't say to use p->page_rect() to use the whole text, though yes you may be right it may happen, but then we can only say "you're getting what you asked for", the docu says pass no rectangle to get the whole text.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>