<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add methods to get and set the font or at least font size in a FormFieldText"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101692#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add methods to get and set the font or at least font size in a FormFieldText"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101692">bug 101692</a>
from <span class="vcard"><a class="email" href="mailto:huj@froreich-bioscientia.de" title="Hans-Ulrich Jüttner <huj@froreich-bioscientia.de>"> <span class="fn">Hans-Ulrich Jüttner</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=101692#c9">comment #9</a>)
<span class="quote">> Any reason you're using isspaces instead of Lexer::isSpace?</span >
No special reason, I just used isspace() from libc because I'm familiar with
it.
If Lexer::isSpace() is equivalent and the preferred way to do it in poppler,
I'll replace isspace() with it.
<span class="quote">>
> In FormFieldText::setTextFontSize if idx is -1 we should give a warning and
> skip doing all the work for nothing, no? Should we even return false in that
> case?</span >
Ok, I'll do that.
<span class="quote">>
> Also i'd prefer if we return -1 in FormFieldText::getTextFontSize if the
> font size is not found, seems error return like for "it failed" than 0, that
> while a weird size i can see some cases in which it is "correct-ish"</span >
Ok, that reasonable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>