<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Sign PDF with digital signature"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99416#c40">Comment # 40</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Sign PDF with digital signature"
href="https://bugs.freedesktop.org/show_bug.cgi?id=99416">bug 99416</a>
from <span class="vcard"><a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> <span class="fn">Albert Astals Cid</span></a>
</span></b>
<pre>(In reply to Adrian Johnson from <a href="show_bug.cgi?id=99416#c37">comment #37</a>)
<span class="quote">> (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=99416#c33">comment #33</a>)
> > (In reply to Adrian Johnson from <a href="show_bug.cgi?id=99416#c30">comment #30</a>)
> > > Created <span class=""><a href="attachment.cgi?id=134043" name="attach_134043" title="Return timezone in timeToDateString">attachment 134043</a> <a href="attachment.cgi?id=134043&action=edit" title="Return timezone in timeToDateString">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=99416&attachment=134043'>[review]</a> [review] [review] [review]
> > > Return timezone in timeToDateString
> > >
> > > Here's the fix to make timeToDateString include the time zone in a portable
> > > way.
> >
> > Adrian, does this mean you're relatively happy with the patch?
>
> I'm not sure which patch you are referring to.</span >
All of them :D
<span class="quote">> Current patch status is:
>
> 1) Added signing of PDF documents via Qt5 interface and with pdfsig
>
> I have a number of major issues with this patch. I have fixed these issues
> in (3).</span >
So you're "happy with conditions" :D
<span class="quote">>
> 2) pdfsig: add -nssdi option v2
>
> Updated documentation based on your feedback.
>
> 3) write document then update byte offsets and sig on disk v2
>
> This fixes all the issues I had with (1).
>
> 4) Return timezone in timeToDateString
>
> In <a href="show_bug.cgi?id=99416#c15">comment 15</a> I requested that the patch use the timeToDateString(). I noted
> that this function currently does not include the timezone. This patch adds
> the time zone. Patch (3) has already changed the signing code to use
> timeToDateString().</span >
This looks good to me. Hans-Ulrich do patches 2) 3) and 4) also look good for
you?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>