<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix warnings and cleanup unused defs"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103050#c55">Comment # 55</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix warnings and cleanup unused defs"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103050">bug 103050</a>
from <span class="vcard"><a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> <span class="fn">Adrian Johnson</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=103050#c31">comment #31</a>)
<span class="quote">> > Fix some -Wundef warnings
>
> I'm actually kind of scared of this patch, we kind of know "it works" as of
> now, and changing this is kind of fragile, but ok i guess</span >
I don't want to commit anything your not entirely happy with. What specifically
concerns you about the patch? It just changes #if ... to #if defined() or
#ifdef for the feature macros. It is less fragile than the existing code where
someone could make a typo eg
#if ENABLED_LIBZ /* should be ENABLED_ZLIB */
and the code will compile without warnings.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>