<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Fix warnings and cleanup unused defs" href="https://bugs.freedesktop.org/show_bug.cgi?id=103050#c62">Comment # 62</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Fix warnings and cleanup unused defs" href="https://bugs.freedesktop.org/show_bug.cgi?id=103050">bug 103050</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>(In reply to Adrian Johnson from <a href="show_bug.cgi?id=103050#c59">comment #59</a>) > (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=103050#c41">comment #41</a>) > > > Make poppler compile of threads not available > > > > I don't understand this one, please explain the rationale of it > > We've got 77 "#ifdef MULTITHREADED" macros all over the code but > MULTITHREADED is always defined. We should either define MULTITHREADED based > on whether threads have been detected or just remove the macro. The former > allows users to build on systems without threads. > > Although the best solution IMHO is too add a no op version of the mutex > class to GooMutex.h for when threads are not available then all the > MULTITHREADED macros can be removed. Hmmm, ok i guess, to be honest i think we shouldn't really worry much about the non multithreaded case, how did you test this? which system without thread support did you use?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>