<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - support tags, links, page labels, outline, metadata in cairo backend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103912#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - support tags, links, page labels, outline, metadata in cairo backend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103912">bug 103912</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=135717" name="attach_135717" title="Fix some bugs in StructTreeRoot">attachment 135717</a> <a href="attachment.cgi?id=135717&action=edit" title="Fix some bugs in StructTreeRoot">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=103912&attachment=135717'>[review]</a>
Fix some bugs in StructTreeRoot
Review of <span class=""><a href="attachment.cgi?id=135717" name="attach_135717" title="Fix some bugs in StructTreeRoot">attachment 135717</a> <a href="attachment.cgi?id=135717&action=edit" title="Fix some bugs in StructTreeRoot">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=103912&attachment=135717'>[review]</a>:
-----------------------------------------------------------------
LGTM
::: poppler/Object.h
@@ +90,5 @@
<span class="quote">> + bool operator() (const Ref& lhs, const Ref& rhs) const {
> + if (lhs.num != rhs.num)
> + return lhs.num < rhs.num;
> + else
> + return lhs.gen < rhs.gen;</span >
We don't need the else after a return</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>