<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - support tags, links, page labels, outline, metadata in cairo backend" href="https://bugs.freedesktop.org/show_bug.cgi?id=103912#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - support tags, links, page labels, outline, metadata in cairo backend" href="https://bugs.freedesktop.org/show_bug.cgi?id=103912">bug 103912</a> from <a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> Adrian Johnson</a> <pre>(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=103912#c9">comment #9</a>) > Comment on <a href="attachment.cgi?id=135717" name="attach_135717" title="Fix some bugs in StructTreeRoot">attachment 135717</a> <a href="attachment.cgi?id=135717&action=edit" title="Fix some bugs in StructTreeRoot">[details]</a> <a href='page.cgi?id=splinter.html&bug=103912&attachment=135717'>[review]</a> [review] > Fix some bugs in StructTreeRoot > > Review of <a href="attachment.cgi?id=135717" name="attach_135717" title="Fix some bugs in StructTreeRoot">attachment 135717</a> <a href="attachment.cgi?id=135717&action=edit" title="Fix some bugs in StructTreeRoot">[details]</a> <a href='page.cgi?id=splinter.html&bug=103912&attachment=135717'>[review]</a> [review]: > ----------------------------------------------------------------- > > LGTM > > ::: poppler/Object.h > @@ +90,5 @@ > > + bool operator() (const Ref& lhs, const Ref& rhs) const { > > + if (lhs.num != rhs.num) > > + return lhs.num < rhs.num; > > + else > > + return lhs.gen < rhs.gen; > > We don't need the else after a return I've pushed this patch with the above change as it fixes a couple of other bug reports. I'll get onto the other patches soon.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>