<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692">bug 105692</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>Created <a href="attachment.cgi?id=138341" name="attach_138341" title="Always respect Annot Rect for AnnotText icons">attachment 138341</a> <a href="attachment.cgi?id=138341&action=edit" title="Always respect Annot Rect for AnnotText icons">[details]</a> <a href='page.cgi?id=splinter.html&bug=105692&attachment=138341'>[review]</a> Always respect Annot Rect for AnnotText icons (2nd part of patch series - based on <a href="https://bugs.freedesktop.org/attachment.cgi?id=138340">https://bugs.freedesktop.org/attachment.cgi?id=138340</a>) Instead of forcing 24x24, always use the size of Annot Rect when drawing icons in user space (even on first rendering - to rephrase Fabios commit message from 7684c325). It fixes the most important part of #105692, imho. For our hardcoded icons we only need 24x24 while we're in appearance XObject coordinate system. For user space, Gfx::drawAnnot does the transformation (translate + scale) to whatever size and position is in Annot Rect. Note: For the same reason the AP BBox can start at (0,0). We don't need an offset. I changed the AP BBox to 0, 0, 24, 24. That's simpler, and other embedded appearance streams I've seen from other PDF writers do it that way, too.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>