<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add missing time.h to some headers"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105766">105766</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Add missing time.h to some headers
</td>
</tr>
<tr>
<th>Product</th>
<td>poppler
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>general
</td>
</tr>
<tr>
<th>Assignee</th>
<td>poppler-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mojca@macports.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=138376" name="attach_138376" title="Add missing time.h plus minor cleanup">attachment 138376</a> <a href="attachment.cgi?id=138376&action=edit" title="Add missing time.h plus minor cleanup">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=105766&attachment=138376'>[review]</a>
Add missing time.h plus minor cleanup
I'm attaching a patch to fix a broken build on some platforms (notable FreeBSD
and NetBSD). Since the time headers are needed in gfile.h not just in gfile.cc,
I moved inclusion of time.h there and made a minor cleanup of code.
Note that #include <ctime.h> does not exist (not even on Mac), it's either
<ctime> or <time.h>. I tested it and that fails. That said, #elif
defined(MACOS) is not defined either, so it doesn't really do any harm, but
it's of no use.
I had to patch poppler/Form.h in the released version because it also lacked
time headers. When preparing the patch I noticed it was already fixed upstream,
but if all other headers are included like <set> and <vector>, meaning that
it's C++ anyway, so it also made more sense to use <ctime> rather than
<time.h>. That one is optional though, it's just cosmetics.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>