<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [PATCH] Implement ArthurOutputDev::axialShadedFill"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103795#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [PATCH] Implement ArthurOutputDev::axialShadedFill"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103795">bug 103795</a>
from <span class="vcard"><a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> <span class="fn">Albert Astals Cid</span></a>
</span></b>
<pre>(In reply to oliver.sander from <a href="show_bug.cgi?id=103795#c11">comment #11</a>)
<span class="quote">> > Which kind of shading it is?
>
> I tried it with all those from the example document you posted in <a href="show_bug.cgi?id=103795#c6">Comment 6</a>.
>
> But it seems that I have to revisit my previous comment a little. I am
> simply experiment using the following hack:
>
> --- a/qt5/src/ArthurOutputDev.cc
> +++ b/qt5/src/ArthurOutputDev.cc
> @@ -777,6 +777,7 @@ void ArthurOutputDev::stroke(GfxState *state)
>
> void ArthurOutputDev::fill(GfxState *state)
> {
> + m_painter.top()->setRenderHint(QPainter::Antialiasing,false);
> m_painter.top()->fillPath( convertPath( state, state->getPath(),
> Qt::WindingFill ), m_currentBrush );
> }
>
> But I just learned that this only works if the resolution we are rendering
> to is high enough (using test-render-to-file-qt5). So this needs more
> thought.
>
> > I can see two solutions:
> > * Add pre/post function calls in gfx.cc before the shading is done
>
> That would be easy, but it would mean a new API in OutputDev.h. It's not on
> me to decide whether that is a good idea.</span >
Do you think it would be a bad idea?
<span class="quote">>
> > * Implemnt the shading in arthuroutputdev, but make the implementation just be
> > disableAA();
> > doWhateverTheGfxCodeDoes();
> > enableAA();
>
> Problematic, because doWhateverTheGfxCodeDoes() is a lot of code.</span >
We can put that "lot of code" in a function to allow for code reuse.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>