<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Render a single annotation with Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=105796#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Render a single annotation with Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=105796">bug 105796</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>(In reply to Tobias Deiminger from <a href="show_bug.cgi?id=105796#c1">comment #1</a>) > Created <a href="attachment.cgi?id=138408" name="attach_138408" title="Move Qt5 output device code out of poppler-page.cc">attachment 138408</a> <a href="attachment.cgi?id=138408&action=edit" title="Move Qt5 output device code out of poppler-page.cc">[details]</a> <a href='page.cgi?id=splinter.html&bug=105796&attachment=138408'>[review]</a> [review] > Move Qt5 output device code out of poppler-page.cc > > Qt5SplashOutputDev, OutputDevCallbackHelper and QImageDumpingArthurOutputDev > had been defined only locally in poppler-page.cc. Factor them out to be > reusable by other source files. They're in one file along with > ArthurOutputDev now. > > Based on master c7a3176. ArthurOutputDev is quite complex as it is now, I don't think it's a good idea to add more stuff to that file. If you want to make those classes available for other files, i'd say poppler-private.h is more a nice place to have them if you don't want to add a new file altogether.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>