<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692">bug 105692</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>(In reply to Tobias Deiminger from <a href="show_bug.cgi?id=105692#c11">comment #11</a>) > Created <a href="attachment.cgi?id=138645" name="attach_138645" title="Apply template method design pattern to Annot::draw (Rev 4)">attachment 138645</a> <a href="attachment.cgi?id=138645&action=edit" title="Apply template method design pattern to Annot::draw (Rev 4)">[details]</a> <a href='page.cgi?id=splinter.html&bug=105692&attachment=138645'>[review]</a> [review] > Apply template method design pattern to Annot::draw (Rev 4) > > Continuous rebasing ¯\_(ツ)_/¯ I like that AnnotAppearanceBuilder... I'm a bit conflicted with this patch. I see it adds some structure, that is always nice, on the other hand it doesn't really save that many lines as shown by the base implementations (that is what we end up reusing) are basically one line each. Also the new structure makes you add the fontResourceDict which is a bit harder to manage than before since now it spans two methods instead of one. On the other hand now we don't create the fonts dict on every draw that is a good thing too (not that it's a hot path but all speedups are good) Let me sleep over it :D Comments either from you or from anyone else that add pros for this patch are also welcome :)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>