<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692">bug 105692</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>Created <a href="attachment.cgi?id=138666" name="attach_138666" title="Alternate all-in-one patch">attachment 138666</a> <a href="attachment.cgi?id=138666&action=edit" title="Alternate all-in-one patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=105692&attachment=138666'>[review]</a> Alternate all-in-one patch This patch tries what was discussed in <a href="show_bug.cgi?id=105692#c14">comment 14</a> and <a href="show_bug.cgi?id=105692#c15">comment 15</a>: - Get rid of Annot::appearBBox member, local AnnotAppearanceBBox'es are enough. - Get rid of Annot::getDrawRect again, no longer needed because Annot::rect always equals draw size. - Keep the template pattern approach (just my own decision atm) - Fix AnnotLine, AnnotTextMarkup, AnnotPolygon, AnnotInk by adjusting Annot::rect (but not annotObj["Rect"]!) to generated appearance. See also [0]. - Fix AnnotText by scaling default appearance (24x24) to size of annotObj["Rect"]. I did some first tests with Okular and it worked as expected. Albert, what do you think, can we proceed this way? Based on master a8e93f4. [0] If I got it right, Acrobat/Reader handles the case the same. See <a href="https://lists.freedesktop.org/archives/poppler/2012-April/008956.html">https://lists.freedesktop.org/archives/poppler/2012-April/008956.html</a> ("[..] generate a new bounding box that incorporates the entire line as that is what one would expect [...]")</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>