<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - PDF compliance: Always respect Annot Rect" href="https://bugs.freedesktop.org/show_bug.cgi?id=105692">bug 105692</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=105692#c12">comment #12</a>) > Comments either from you or from anyone else that add pros for this patch > are also welcome :) The size fix (not submitted yet) for the remaining types like AnnotLine and AnnotPolygonfrom will probably look something like this: void Annot::getRect(double *x1, double *y1, double *x2, double *y2) const { - *x1 = rect->x1; - *y1 = rect->y1; - *x2 = rect->x2; - *y2 = rect->y2; + PDFRectangle drawRect = getDrawRect(); + *x1 = drawRect.x1; + *y1 = drawRect.y1; + *x2 = drawRect.x2; + *y2 = drawRect.y2; } I.e. always report the actually drawn size instead of the size stored in /Rect, because it can differ in corner cases and the drawn size is what's more important to API clients. That measure is only possible if there exists that getDrawRect method from <a href="attachment.cgi?id=138645" name="attach_138645" title="Apply template method design pattern to Annot::draw (Rev 4)">attachment 138645</a> <a href="attachment.cgi?id=138645&action=edit" title="Apply template method design pattern to Annot::draw (Rev 4)">[details]</a> <a href='page.cgi?id=splinter.html&bug=105692&attachment=138645'>[review]</a>. That would be a (however still fictional) pro from my point of view.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>