<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] Add support for hide action in PDF Forms" href="https://bugs.freedesktop.org/show_bug.cgi?id=105758#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] Add support for hide action in PDF Forms" href="https://bugs.freedesktop.org/show_bug.cgi?id=105758">bug 105758</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>Thanks and sorry for the delay on reviewing! I was wondering if to future proof the Qt5 API and its users (the core API can be changed as much as we want), it would make sense to change QString targetName() const; be QVector<QString> targets() const; And for now we just return one value. This way when we implement cases b/c the application that uses poppler-qt5 will hopefully magically just work? Also can you please change the Qt5::LinkHide constructor to be like the LinkOCGState one, i.e. so that it gets the private passed in, this way it's clear "normal users" should not create one, and if we need to pass more stuff to the constructor we don't break ABI or anything since it's still a pointer.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>