<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:aheinecke@intevation.de" title="Andre Heinecke <aheinecke@intevation.de>"> <span class="fn">Andre Heinecke</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Patch] Add support for hide action in PDF Forms"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105758">bug 105758</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #138372 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Patch] Add support for hide action in PDF Forms"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105758#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Patch] Add support for hide action in PDF Forms"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105758">bug 105758</a>
from <span class="vcard"><a class="email" href="mailto:aheinecke@intevation.de" title="Andre Heinecke <aheinecke@intevation.de>"> <span class="fn">Andre Heinecke</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=138702" name="attach_138702" title="Patch to add support for the hide action - Updated 1">attachment 138702</a> <a href="attachment.cgi?id=138702&action=edit" title="Patch to add support for the hide action - Updated 1">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=105758&attachment=138702'>[review]</a>
Patch to add support for the hide action - Updated 1
(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=105758#c1">comment #1</a>)
<span class="quote">> Thanks and sorry for the delay on reviewing!</span >
No problem. Thanks for the review :-)
<span class="quote">> I was wondering if to future proof the Qt5 API and its users (the core API
> can be changed as much as we want), it would make sense to change
> QString targetName() const;
> be
> QVector<QString> targets() const;
>
> And for now we just return one value. This way when we implement cases b/c
> the application that uses poppler-qt5 will hopefully magically just work?</span >
Good idea. I'll change the okular patch accordingly.
<span class="quote">> Also can you please change the Qt5::LinkHide constructor to be like the
> LinkOCGState one, i.e. so that it gets the private passed in, this way it's
> clear "normal users" should not create one, and if we need to pass more
> stuff to the constructor we don't break ABI or anything since it's still a
> pointer.</span >
Changed. I didn't understand why the OCGState used this pattern and oriented
myself on the others ;-)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>