<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mkasik@redhat.com" title="Marek Kasik <mkasik@redhat.com>"> <span class="fn">Marek Kasik</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash on PDF with wrong attachment"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106137">bug 106137</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #138928 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash on PDF with wrong attachment"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106137#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash on PDF with wrong attachment"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106137">bug 106137</a>
from <span class="vcard"><a class="email" href="mailto:mkasik@redhat.com" title="Marek Kasik <mkasik@redhat.com>"> <span class="fn">Marek Kasik</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=138946" name="attach_138946" title="Patch fixing this issue - modified">attachment 138946</a> <a href="attachment.cgi?id=138946&action=edit" title="Patch fixing this issue - modified">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=106137&attachment=138946'>[review]</a>
Patch fixing this issue - modified
(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=106137#c3">comment #3</a>)
<span class="quote">> Why are you adding the FileSpec.cc code? the EmbFile constructor already
> checks for the object being an stream and EmbFile has an isOk you should be
> using. </span >
It is for the case when the referenced object is null object and not a stream.
I've modified the patch so that the object is tested for being a stream in glib
frontend and does not modify FileSpec.cc at all.
Or we can alternatively fetch the object in constructor of FileSpec and check
for being stream so that isOk() covers also this case.
<span class="quote">> I'd prefer not to change that since your change would actually most probably
> break the qt5 frontend code.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>