<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Patch] Skip XRef gaps in PDFDoc save methods"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107057#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Patch] Skip XRef gaps in PDFDoc save methods"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107057">bug 107057</a>
from <span class="vcard"><a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> <span class="fn">Albert Astals Cid</span></a>
</span></b>
<pre>But we can not have a different problem, no?
XRef::getEntry does
XRefEntry *XRef::getEntry(int i, GBool complainIfMissing)
{
if (i >= size || entries[i].type == xrefEntryNone) {
// stuff
}
return &entries[i];
}
and the saving code does
for(int i=0; i<xref->getNumObjects(); i++) {
xref->getEntry(i);
and since xref->getNumObjects() is xref->size, if we make it that it ignores
the entries[i].type == xrefEntryNone part because we pass
DoNotTryToRecoverIfNone then it always just returns &entries[i] directly,
right?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>