<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] Skip XRef gaps in PDFDoc save methods" href="https://bugs.freedesktop.org/show_bug.cgi?id=107057#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [Patch] Skip XRef gaps in PDFDoc save methods" href="https://bugs.freedesktop.org/show_bug.cgi?id=107057">bug 107057</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=107057#c11">comment #11</a>) > But we can not have a different problem, no? Ah thanks, you're right of course. Sorry, I overlooked that. The new patch in <a href="attachment.cgi?id=140484" name="attach_140484" title="Skip XRef xrefEntryNone entries on incremental update and full rewrite (v2)">attachment 140484</a> <a href="attachment.cgi?id=140484&action=edit" title="Skip XRef xrefEntryNone entries on incremental update and full rewrite (v2)">[details]</a> <a href='page.cgi?id=splinter.html&bug=107057&attachment=140484'>[review]</a> does basically what you suggested, I just changed the enum names a bit. I thought it's a bit better to name the actions "load", instead of "recover", because "load from file if not yet in memory" is the primary intention of a getEntry() caller if they select the new LoadSilentlyIfMissing or LoadAndComplainIfMissing option. Recovery is only a rare secondary step if loading failed. Had no time to test the new patch yet. I will repeat the steps from <a href="show_bug.cgi?id=107057#c1">comment 1</a> on Mondays.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>