<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler Qt5 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler Qt5 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a>
from <span class="vcard"><a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> <span class="fn">Tobias Deiminger</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=140496" name="attach_140496" title="This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator">attachment 140496</a> <a href="attachment.cgi?id=140496&action=edit" title="This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=107151&attachment=140496'>[review]</a>
This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator
Review of <span class=""><a href="attachment.cgi?id=140496" name="attach_140496" title="This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator">attachment 140496</a> <a href="attachment.cgi?id=140496&action=edit" title="This patch adds font color in poppler-qt5 frontend by introducing 'rg' operator">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=107151&attachment=140496'>[review]</a>:
-----------------------------------------------------------------
::: qt5/src/poppler-annotation.h
@@ +483,5 @@
<span class="quote">> void setTextIcon( const QString &icon );
>
> QFont textFont() const;
> + QColor textColor() const;
> + void setTextFont( const QFont &font, const QColor &color );</span >
Can we split setTextFont into two?
void setTextFont( const QFont &font );
void setTextColor( const QColor &color );
There are two reasons why: Make it symmetrical to the textFont/textColor get
methods. And more important, changing setTextFont signature would break API and
ABI compatibility of the public poppler-annotations.h interface. Adding a new
non-virtual method however keeps both API and ABI compatible. I don't know the
exact poppler API policy, but that should be considerable anyway.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>