<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a> from <a class="email" href="mailto:sankhla.dileep96@gmail.com" title="Dileep Sankhla <sankhla.dileep96@gmail.com>"> Dileep Sankhla</a> <pre>(In reply to Tobias Deiminger from <a href="show_bug.cgi?id=107151#c4">comment #4</a>) > (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=107151#c3">comment #3</a>) > > I'm not very happy with the appearance creation being in the qt frontend, > > but well it kind of was there already so i guess we can let it pass, but i > > really don't like the new method that parses the color, can't we use > > AnnotFreeText::parseAppearanceString ? > > I definitely agree that creating and parsing DA should be the concern of > poppler/Annot.cc, probably class AnnotFreeText. > > But Dileep just carried on what was already there, not only regarding > creation but also regarding parsing: The long existing > TextAnnotation::textFont also parses DA in Qt5 frontend. > > To be consistent, we should then move all the DA creation and parsing to > poppler/Annot.cc. Both existing and new functionality. Albert, would that be > good for you? Dileep, do you think it's possible for you? As basically I'm working on the project Okular, that uses the Qt5 frontend of the poppler, I think it should be added and extended to where it has initially existed. As I passed the second evaluation, I guess it should be marked as "done" as in the remaining 16 days, I have to accomplish the remaining tasks.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>