<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler Qt5 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>"passing second evaluation" was a broad decission. It doesn't mean a particular patch is ready to land. Albert is the poppler maintainer, he has to be confident the patch is good for the project before he can merge it. That's independent from GSoC. If the patch is sub-par, but the patch was mainly blueprinted from existing code, then the existing code is sub-par too (see TextAnnotationPrivate::toAppearanceString, TextAnnotation::textFont). Let's focus on how to fix both and get this patch ready. I'll come up with some ideas soon, don't hesitate to be faster.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>