<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler Qt5 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler Qt5 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a>
from <span class="vcard"><a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> <span class="fn">Tobias Deiminger</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=107151#c3">comment #3</a>)
<span class="quote">> I'm not very happy with the appearance creation being in the qt frontend,
> but well it kind of was there already so i guess we can let it pass, but i
> really don't like the new method that parses the color, can't we use
> AnnotFreeText::parseAppearanceString ?</span >
I definitely agree that creating and parsing DA should be the concern of
poppler/Annot.cc, probably class AnnotFreeText.
But Dileep just carried on what was already there, not only regarding creation
but also regarding parsing: The long existing TextAnnotation::textFont also
parses DA in Qt5 frontend.
To be consistent, we should then move all the DA creation and parsing to
poppler/Annot.cc. Both existing and new functionality. Albert, would that be
good for you? Dileep, do you think it's possible for you?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>