<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c17">Comment # 17</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add font color in Poppler" href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a> from <a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> Tobias Deiminger</a> <pre>(In reply to Dileep Sankhla from <a href="show_bug.cgi?id=107151#c16">comment #16</a>) > Created <a href="attachment.cgi?id=140935" name="attach_140935" title="This patch includes Annot.cc to create and parse DA string">attachment 140935</a> <a href="attachment.cgi?id=140935&action=edit" title="This patch includes Annot.cc to create and parse DA string">[details]</a> <a href='page.cgi?id=splinter.html&bug=107151&attachment=140935'>[review]</a> [review] > This patch includes Annot.cc to create and parse DA string You mailed me yesterday, regarding review and fixing a segfault in your yet unpublished patch. Seems I was too slow, you fixed it yourself :) I have a local patch pending anyway now... > Thanks @Tobias and @Albert for the review comments. I hope this patch is > what you expected at least for the font color with "invalid_font" Tf. > The font family patch will be patched from this current patch for including > font families in poppler. I think it's good, there are some minor issues only, like adding a bit more const and performing a nullptr check on delete of DefaultAppearance::fontColor. It would be in my local patch, is it ok for you if we merge? Finally, we should run available automated tests. Albert, I know how to execute poppler/qt5/tests/*. What about poppler/regtest/poppler-regtest, are there examples how to use it?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>