<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151#c29">Comment # 29</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add font color in Poppler"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107151">bug 107151</a>
from <span class="vcard"><a class="email" href="mailto:haxtibal@posteo.de" title="Tobias Deiminger <haxtibal@posteo.de>"> <span class="fn">Tobias Deiminger</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=107151#c27">comment #27</a>)
<span class="quote">> @@ -2872,7 +2924,8 @@ void AnnotFreeText::generateFreeTextAppearance()
> fontTag is never used not passed anywhere.</span >
Alright. Leak, definitely. Wasn't aware of that place.
How about changing parseAppearanceString signature to
void AnnotFreeText::parseAppearanceString(..., GooString** fontTag)?
Then we can pass nullptr to indicate we don't need the fontTag.
Else we had a useless new-delete cycle in generateFreeTextAppearance.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>