[poppler] [PATCH] initial clean poppler-qt implementation

Albert Astals Cid tsdgeos at yahoo.es
Fri Apr 1 08:03:58 PST 2005


I've lost the original mail so i'm answering without any quoting, sorry

in the next few lines we = kpdf

A few things we have to say about this:

### PopplerDocument *PopplerDocument::load(const QString &filePath) ###
 - We can accept the current implementation, what we will do is check if the 
result is null, if it is report there was an error opening the file, if we 
got a document and is locked then ask for a password and try to unlock it. It 
is something "similar" to what we do now.

### void PopplerPage::renderToPixmap(QPixmap **q) ###
 - How expensive is creating a new SplashOutputDev each time you call 
renderToPixmap? Maybe it could be worth creating one at the begining and 
reuse it
 - We have an option to draw with paperColor different than wait so either we 
need a QColor parameter to renderToPixmap or a setPaperColor(QColor c) 
operation

### PDFDisplay class ###
This is for testing only, isn't?

Albert 



More information about the poppler mailing list