[poppler] [PATCH] poppler-qt again

Kristian Høgsberg krh at bitplanet.net
Tue Apr 5 18:21:43 PDT 2005


Jeff Muizelaar wrote:
> Attached is my cvs candidate for the begining of poppler-qt.
> 
> Changes of Note:
> 	* uses Poppler namespace instead of Poppler prefix
> 	* no more namespace polution with PDFDoc
> 	* renderSlice instead of just render
> 	* nearly verbatim inclusion of some of meta-data functions
> 	  from kpdf and kfile_pdf
> 
> With this patch it should be pretty trivial to convert kfile_pdf to
> poppler-qt.

Two more comments: I think we should keep all state for 
Poppler::Document and Poppler::Page in the opaque DocumentData and 
PageData structs.  That way it's easier to add or remove fields to the 
classes without breaking ABI.  Oh, and I'm not a big fan of the word 
'slice' (reminds me of pizza), and I would just call the render method 
'renderToPixmap'.  Especially since it is the only render method we 
provide, there is no need to emphasize that it's only rendering part of 
the page.

Other than that, very nice, please commit...

cheers,
Kristian


More information about the poppler mailing list