[poppler] [Qt backend] page::getText

Albert Astals Cid tsdgeos at yahoo.es
Wed Apr 20 10:59:49 PDT 2005


Updated patch.

Albert

A Dimecres 20 Abril 2005 17:45, vàreu escriure:
> On Tue, Apr 19, 2005 at 11:40:54PM +0200, Albert Astals Cid wrote:
> > Hi, this function adds page::getText to the Qt backend, it accepts a
> > rectangle as parameter. If the rectangle is null the whole page text is
> > returned, if not it returns the text inside that rectangle.
> >
> > It also features like it seems like a memory leak fix, as doing
> >
> > DocumentData *doc = new DocumentData(new
> > GooString(QFile::encodeName(filePath)), NULL);
> >
> > seems like a good way to never recover the memory new'ed at that new
> > Goostring
>
> The file path string is deleted by the PDFDoc deconstructor (see
> PDFDoc.cc:166). However, it does look like the passwords are never
> freed...
>
> Other than that it looks pretty reasonable. I am going to look it over
> more thoroughly, and then commit.
>
> -Jeff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler.patch
Type: text/x-diff
Size: 4747 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20050420/569c7c4a/poppler-0001.bin


More information about the poppler mailing list