[poppler] Fix for my fix

Albert Astals Cid aacid at kde.org
Tue Aug 2 02:48:38 EST 2005

Ok, there's the corrected patch, agree to commit?


A Dilluns 01 Agost 2005 16:52, vàreu escriure:
> Albert Astals Cid wrote:
> > Hi, this patch fixes a problem i have seen in a pdf (can not share it)
> > where calling str->reset() to times in DCTStream::reset causes it to
> > misbehave.
> >
> > To not call str->reset() and still skip the gargabe we find at the
> > beginning of the stream, i've modified str_fill_input_buffer(...) so that
> > in the two first cases it returns the JPEG markers and then the rest of
> > the data (that will be after the garbage).
> >
> > Should the int be declared static? I'm sometimes lost with static when it
> > does not apply to classes.
> >
> > What do you think?
> The idea of the patch is good, but the integer counter must be part of
> struct str_src_mgr, declared in DCTStream.h and initialized in the
> DCTStream constructor.  With the current global variable, there's only
> one 'i' in the entire program and if you have two DCTStreams in a
> document, only the first one will work.
> > Albert
> >
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.fix
Type: text/x-diff
Size: 1621 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20050801/35eec471/patch.bin

More information about the poppler mailing list