[poppler] poppler/qt4/src: Makefile.am, 1.1, 1.2 poppler-fontinfo.cc, NONE, 1.1 poppler-qt4.h, 1.12, 1.13 poppler-textbox.cc, NONE, 1.1

[Albert Astals Cid]

Yeah, my fault, i had just discovered it when your mail arrived.

Albert

A Diumenge 04 Desembre 2005 12:26, Wilfried Huss va escriure:
> Am Sunday, 4. December 2005 11:09 schrieb Brad Hards:
> > On Sunday 04 December 2005 09:20 am, Albert Astals Cid wrote:
> > > Update of /cvs/poppler/poppler/qt4/src
> > > In directory gabe:/tmp/cvs-serv8057/qt4/src
> > >
> > > Modified Files:
> > > 	Makefile.am poppler-qt4.h
> > > Added Files:
> > > 	poppler-fontinfo.cc poppler-textbox.cc
> > > Log Message:
> > >  * qt4/src/poppler-qt4.h:
> > >  * qt4/src/poppler-fontinfo.cc:
> > >  * qt4/src/poppler-textbox.cc: Remove implementation of that classes
> > > from the header, use pimpl
> >
> > Albert,
> >
> > I think that this change is broken. I'm getting segfaults in the test
> > apps.
> >
> > I've committed a unit test that shows the problem. Do make check.
> >
> > I'd really like to see this fixed before our release. Otherwise this
> > release is going to be unusable for Qt4.
>
> It also crashes for Qt3. The problem is the missing copy-constructor in the
> FontInfo class. When put into the QValueList, the FontInfoData* becomes
> a dangling pointer.
>
> The attached patch fixes this. I haven't looked at the Qt4 code, but the
> problem is probably the same.
>
> Greetings,
> Wilfried.

		
______________________________________________ 
Renovamos el Correo Yahoo! 
Nuevos servicios, mநூs seguridad 
http://correo.yahoo.es