[poppler] cropBox can not be bigger than mediaBox

Albert Astals Cid aacid at kde.org
Mon Dec 12 10:30:37 PST 2005


A Dilluns 12 Desembre 2005 02:30, Martin Schröder va escriure:
> On 2005-12-11 21:17:37 +0100, Albert Astals Cid wrote:
> > Agree to commit?
>
> +    if (cropBox.x2 - cropBox.x1 > mediaBox.x2 - mediaBox.x1 ||
> +        cropBox.y2 - cropBox.y1 > mediaBox.y2 - mediaBox.y1)
> +            cropBox = mediaBox;
>
> Btw: The || is probably false, as you loose both dimensions when
> at least one is false -- and the other might be right.

Not imho, if one dimension is bad means the generator did something completely 
wrong so i prefer not to trust cropBox at all.

Albert

>
> Best
>     Martin

		
______________________________________________ 
Renovamos el Correo Yahoo! 
Nuevos servicios, más seguridad 
http://correo.yahoo.es


More information about the poppler mailing list