[poppler] change FontInfo::type() to enumerated value

Kristian Høgsberg krh at bitplanet.net
Sun Jul 3 05:55:47 PDT 2005


Brad Hards wrote:
> In working through the Qt4 bindings for FontInfo, I've found that having the 
> font type returned as a GooString isn't all that nice. It would be much nicer 
> to have an enumerated type (which it is in GfxFontInfo). So my proposal is to 
> make FontInfo::type() return an enumerated value, and to add 
> FontInfo::typeName() which return a GooString, in case anyone wants it.
> 
> Any concerns with this patch?

I think it's fine, go for it.

Kristian


More information about the poppler mailing list