[poppler] Kpdf patches status

Martin Kretzschmar m_kretzschmar at gmx.net
Sun May 1 09:22:50 PDT 2005

Am Sonntag, den 01.05.2005, 15:44 +0200 schrieb Albert Astals Cid:
> Please comment on patches whose status is not "Done" becasue from people's 
> comments about poppler and freedesktop

LC_NUMERIC fix at printing 
Not integrated   Patch is wrong?

I said that the patch is not the best solution.

I had a look at the LC_NUMERIC problems in the existing code this
weekend. As it turns out, similar fixes that are already in xpdf code
are wrong. They try to save the old locale and restore it afterwards.
But they get the saving part wrong (setlocale returns the old value only
when called with NULL, existing code always uses "C" immediately).

As a result of this bug, the patch doesn't do any harm at the moment
(and has an effect only if the program calls setlocale between loading a
PDF and printing it AFAICS). The patch might as well be committed and
the proper fix be made when someone fixes all setlocale calls/uses of
atof/printf %f etc.


More information about the poppler mailing list