[poppler] Patch: Change Splashbitmap RGB8 to 32bits internal

[Jeff Muizelaar]

On Tue, Apr 04, 2006 at 09:48:53PM +0200, Albert Astals Cid wrote:
> A Dimarts 04 Abril 2006 20:55, vàreu escriure:
> > On Tue, Apr 04, 2006 at 08:29:15PM +0200, Albert Astals Cid wrote:
> > > I've not tested the patch, but asuming it works (that i guess it will) is
> > > anyone against this?
> >
> > The glib binding need to be adjusted if this goes in.
> 
> Of course, i only wanted to ask it people disagreed in modyfing splashbitmap 
> so that it uses a bit more of memory for the sake of having faster copying to 
> the destination "pixmap".
> 
> I don't know how you guys handle that in glib frontend, but in Qt we "copy" 
> the splashbitmap to a QImage that is always 32 bit data and then "delete" the 
> splashbitmap so we get faster copying and no increase in memory usage.
> 
> Does GTK provide a 24bit pixmap/image structure and so increasing this to 32 
> would hurt you?

The way it looks to me is that the caller determines whether it is 24 or
32 bits. So I don't think increasing to 32 bits hurts the glib bindings.
However, I didn't write the glib bindings and I don't care much about
the splash backend.

-Jeff