[poppler] Patch: Change Splashbitmap RGB8 to 32bits internal

Martin Kretzschmar m_kretzschmar at gmx.net
Tue Apr 4 15:44:14 PDT 2006


On 4/4/06, Albert Astals Cid <aacid at kde.org> wrote:
> A Dimarts 04 Abril 2006 11:42, Frank Meerkoetter va escriure:
> > Hello,
> >
> > this patch changes the internal format used by SplashBitmap for mode RGB8
> > to 32bits. The first three byte are RGB and the last one is a fixed alpha.
> > This allows the wrappers to use a fast memcopy when copying data out
> > of Splashbitmaps instead of the getPixel()/setPixel() loop currently
> > used.
> >
> > The only wrapper i've touched is the QT3 wrapper because i don't have QT4
> > or Gnome around.
>
> I've not tested the patch, but asuming it works (that i guess it will) is
> anyone against this?

Would it make sense to add this format as an additional format (instead of a
replacement) have advantages? I did this once in evince's past, so I
know it's not
hard, but I don't know if it's necessary (e.g. would it make future
merges from xpdf
harder/easier?).

Martin


More information about the poppler mailing list