[poppler] Patch: Change Splashbitmap RGB8 to 32bits internal

Frank Meerkötter frank at meerkoetter.org
Wed Apr 5 12:50:31 PDT 2006


Leonard Rosenthol wrote:

> At 02:12 AM 4/5/2006, Frank Meerkötter wrote:
>
>> i haven't found a mode named RGBA.
>
>
>         Sorry - it's ARGB8 defined in SplashTypes.h
>
> enum SplashColorMode {
>   splashModeMono1,              // 1 bit per component, 8 pixels per 
> byte,
>                                 //   MSbit is on the left
>   splashModeMono8,              // 1 byte per component, 1 byte per pixel
> [...]
>   ,
>   splashModeCMYK8,              // 1 byte per component, 4 bytes per 
> pixel:
>                                 //   CMYKCMYK...
>   splashModeACMYK8              // 1 byte per component, 5 bytes per 
> pixel:
>                                 //   ACMYKACMYK
> #endif
> };
>
>         In which case, I would just add a NEW enum, splashModeRGBA8.  
> Then find all instances of ARGB8, copy/paste and modify.   That way 
> folks who want RGB can get RGB and those that also want an alpha can 
> have that.

Hi Leonard,

im afraid it isn't that easy. ARGB8 isn't implemented completely. Images
for instance are missing (Splash::drawImage).

Regards,
   Frank


More information about the poppler mailing list