[poppler] Support for building with the Microsoft compiler

[Reece Dunn]

Jeff Muizelaar wrote:
> On Thu, Apr 13, 2006 at 10:49:21PM +0100, Reece Dunn wrote:
> > Hi all,
> > 
> > The supplied patch adds support for the Microsoft compiler, plus a few minor corrections. This is a run down of the changes:
> > 
> > *  msvc doesn't like using __cdecl on constructs like void __cdecl ( *f )( int );
> > *  made fontconfig optional;
> 
> I am not really a fan of littering the code with #ifdefs. It would be
> better if you added an implementation of the needed fontconfig stuff
> that did nothing. e.g.
> Instead of ifdefing calls to FcInit() the following declaration could be
> put in a place like poppler-config.h
> 	static void FcInit() {};

I had a look at this and it would be too messy. BTW, I am with you on not
liking code to be littered with #ifdefs.

> Alternatively, the font matching code could be abstracted out so that
> fontconfig or the windows equivalent is compiled depending on the
> platform used.

This would be the better option. I'll look into this and resubmit those sections.

What about the other areas of the patch? I take it you are happy with those.

- Reece
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/