[poppler] [PATCH] GLib method to read a PDF from memory

[Jeff Muizelaar]

On Wed, Dec 20, 2006 at 03:06:02PM -0800, Brad Taylor wrote:
> Hey,
> 
> > This implementation copies a lot of the code poppler_document_from_file
> > which is not ideal. It'd be better if the duplicate code could be
> > shared.
> 
> Understandable.  I've cooked up a new patch with a shared method.
> Should this method be inlined, or do we mind adding another method to
> the stack?

I don't see any reason to inline it. However, it should probably be made
static (gcc will inline it if it thinks that it's appropriate).

Is there any reason the GlobalParams and password stuff can't be moved
into the common function? Also, I don't see any reason for the start
parameter. I'd imagine most users would pass in zero. If the user wants
to start at a different place, I think it makes sense for them to do the
pointer addition themselves.

-Jeff