[poppler] evas support for poppler

Vincent Torri vtorri at univ-evry.fr
Mon Jan 9 12:26:14 PST 2006


Hello,

I have re-worked a bit the evas binding. The archive contains:
* a diff of configure.ac
* a dif of the toplevel Makefile.am
* poppler-evas.pc.in
* the subdir evas/ with the .h, .cc, the test app and Makefile.am

Some comments:

1) in the configure.ac, i've only tested if evas and ecore are installed. 
I've not add some --disable-evas. Should I add it ?

2) the headers are all commented, but my english is ugly. Maybe someone 
should read to fix it :)

3) I don't know what licence to use. What should I use ?

4) there are some functions that does not work correctly : 
  evas_poppler_page_text_get
and
  evas_poppler_page_text_find
I don't really know why.

5) all the utf8 stuff is not supported, simply because I have no idea on 
how to manage it

I have tested the binding and even made a widget for one of the toolkit, 
and it seems to work great. Btw, that library is quite good.

I would also be glad if someone take a bit of time to try this code

Thank you

Vincent

On Wed, 28 Dec 2005, Brad Hards wrote:

> On Wednesday 28 December 2005 07:07 am, Vincent Torri wrote:
> > I would like to have your comments, remarks, etc.. about how to improve
> > the code, and what i have to do for it to be committed (if the developpers
> > are interested, of course)
> I have some detailed comments, but the big question is whether you are willing 
> to maintain it? I don't see any real problem with having evas bindings in the 
> tree, and they don't need to offer the same  capabilities as glib or qt or 
> whatever, but they do need to be maintained if they are going to keep 
> working.
> 
> Detail stuff (based on a really quick review)
> * Must have appropriate copyright (i.e. recognise the source of the code, and 
> license your changes)
> * Ideally would have some documentation 
> * Some of the function names look strange (eg document_is_copiable() probably 
> should be something like document_is_copyable()).
> * There is a hardcoded path in the test app that will only work for you.
> * The patch / tarball has a lot of generated files (libraries and object 
> files, dependencies). Please leave those out - they cannot be committed to 
> CVS and are only applicable to your configuration.
> 
> Brad
> 



More information about the poppler mailing list