[poppler] [PATCH] Memory leaks

[Albert Astals Cid]

A Dilluns 08 Maig 2006 19:11, Carlos Garcia Campos va escriure:
> Hi all,
Hi

> I've been playing with valgrind for a while with evince and I've caught
> several leaks in poppler.
>
> Here is a patch that fixes some leaks:
>
> http://carlosgc.linups.org/files/poppler-memleaks.diff

i omit the glib patches as there's better people to comment.

i'd say Catalog.cc patch is wrong, if you delete the Cstring of a GooString 
the GooString ends up with the inside data dead as what getCString returns is 
not a copy of the data is the data itself.

in PDFDoc.cc is there really any possibility of reaching setup() with xref not 
beign NULL?

Also i disagree we should refcount GlobalParams from within the lib, because 
who creates now the globalparams now? Not the lib, but the lib decides to 
delete globaparams when it thinks its no more needed? Nahhh, bad idea.

poppler/TextOutputDev.cc is for krh.

So no patch i have enough karma/mood to commit ;-)

Albert

		
______________________________________________ 
LLama Gratis a cualquier PC del Mundo. 
Llamadas a fijos y mந்viles desde 1 cளூntimo por minuto. 
http://es.voice.yahoo.com