[poppler] poppler: ChangeLog,1.380,1.381

[Vincent Torri]

On Thu, 25 May 2006, Albert Astals Cid wrote:

> A Dimecres 24 Maig 2006 07:10, Vincent Torri va escriure:
>> Why did you give the suffix Qt ? That colorspace has nothing to do with
>> Qt. Qt is not the only library that uses argb32 colorspace. In addition,
>> giving (adding ?) correct colorspace names would be a good idea (RGB24,
>> ARGB32, RGBA32, etc...).
>
> Any suggestion for a better name? ARGB8 is already taken (by a code that does
> not work as it should) so think a better name.

ARGB32 is what is often used for rgb colorspaces with alpha channel (with 
that order in MSB, iirc), and I think that it's that order that is used 
in poppler, in the case we are discussing. I would not use just RGB32.

>
> Anyway it's just a name, there's nothing that prevents you using it.

indeed, but for now, i'll not use it. It must be changed, really.

Vincent

> Albert
>
>>
>> Vincent
>>
>> On Tue, 23 May 2006, Albert Astals Cid wrote:
>>> Update of /cvs/poppler/poppler
>>> In directory kemper:/tmp/cvs-serv10254
>>>
>>> Modified Files:
>>> 	ChangeLog
>>> Log Message:
>>>        * poppler/SplashOutputDev.cc:
>>>        * qt4/src/poppler-private.h:
>>>        * splash/Splash.cc:
>>>        * splash/SplashBitmap.cc:
>>>        * splash/SplashTypes.h: bring splashModeRGB8 back to the old code
>>>        (before Frank's patch), create splashModeRGB8Qt that has Frank's
>>>        codepath and is used by Qt frontends. Fixes corruption on
>>>        other programs expecting the old behaviour.
>>>
>>> Remember dude we are now a lib! you can not change behaviour from one day
>>> to another!
>>>
>>> /me hits himself
>>>
>>>
>>>
>>> Index: ChangeLog
>>> ===================================================================
>>> RCS file: /cvs/poppler/poppler/ChangeLog,v
>>> retrieving revision 1.380
>>> retrieving revision 1.381
>>> diff -u -d -r1.380 -r1.381
>>> --- ChangeLog	23 May 2006 19:16:37 -0000	1.380
>>> +++ ChangeLog	23 May 2006 20:49:16 -0000	1.381
>>> @@ -1,3 +1,14 @@
>>> +2006-05-21  Albert Astals Cid <aacid at kde.org>
>>> +
>>> +	* poppler/SplashOutputDev.cc:
>>> +	* qt4/src/poppler-private.h:
>>> +	* splash/Splash.cc:
>>> +	* splash/SplashBitmap.cc:
>>> +	* splash/SplashTypes.h: bring splashModeRGB8 back to the old code
>>> +	(before Frank's patch), create splashModeRGB8Qt that has Frank's
>>> +	codepath and is used by Qt frontends. Fixes corruption on
>>> +	other programs expecting the old behaviour.
>>> +
>>> 2006-05-23  Kristian Høgsberg  <krh at redhat.com>
>>>
>>> 	* qt4/src/Makefile.am (libpoppler_qt4_la_SOURCES): Add missing
>>>