[poppler] Printing support in poppler-qt

Stefan Kebekus stefan.kebekus at math.uni-koeln.de
Wed May 31 23:13:59 PDT 2006


Am Donnerstag 01 Juni 2006 08:10 schrieb Jeff Muizelaar:
> On Thu, Jun 01, 2006 at 07:11:50AM +0200, Stefan Kebekus wrote:
> > On Wednesday 31 May 2006 22:03, Albert Astals Cid wrote:
> > > Do we really need
> > >
> > > +  const char *of = file.latin1();
> > > +  char *tf = new char[strlen(of)+10];
> > > +  strcpy(tf, of);
> > >
> > > doesn't using file.latin1() work?
> >
> > The trouble is, file.latin1() returns a "const char *", but the method
> > we're calling takes a "char *".
>
> It would be better to change the PSOutputDev to take a const char *.

Ok, I agree. However, I am not sure I should mingle with that code --because I 
don't understand it. Would you do the change, please?

> Also why the +10?

Pure paranoia.

Best,

Stefan.
-- 
Universität zu Köln
Mathematisches Institut
Weyertal 86-90
50931  Köln / Germany

Phone: +49 (0)221 470-2890
http://www.mi.uni-koeln.de/~kebekus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20060601/0c1dd75a/attachment.pgp


More information about the poppler mailing list