[poppler] [PATCH] poppler-qt links

Brad Hards bradh at frogmouth.net
Thu Sep 7 02:48:10 PDT 2006


On Thursday 07 September 2006 19:07, Wilfried Huss wrote:
> Hi,
>
> attached are two patches (for the qt3 and qt4 bindings) which change
> Page::links() in a way to make it work correctly even if the render
> function was not called with doLinks=true previously. The current code
> results in a crash in such a situation.
I'm not sure I fully understand this code, but it looks like you are 
recalculating the links every time.
Have you timed this?
Is it worth trying to cache it?

Also, would it be possible to add a test case that shows the problem you are 
fixing?

Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20060907/cef00632/attachment.pgp


More information about the poppler mailing list