[poppler] XPDF 3.02 merged in work branch

[Jeff Muizelaar]

On Fri, Apr 13, 2007 at 08:55:23PM -0400, Jeff Muizelaar wrote:
> On Fri, Apr 13, 2007 at 08:45:41PM -0400, Jeff Muizelaar wrote:
> > On Fri, Apr 13, 2007 at 05:11:48PM +0200, Julien Rebetez wrote:
> > > On Fri, 2007-04-06 at 16:30 +0200, Albert Astals Cid wrote: 
> > > > * Merge Annot [1], Julien?
> > > 
> > > The attached patch should do the job.
> > > Aside from merging xpdf 3.02 Annot-related changes, it fixes a bug with
> > > an assert in GooString's constructor.
> > 
> > http://infidigm.net/~jeff/forms/Javascripts.pdf still crashes with this
> > patch applied.
> >
> It looks like the problem is with these lines:
> Annot.cc:      appearDict.dictAdd("Resources", drObj.copy(&resObj));
> Annot.cc:    appearDict.dictAdd("Length", obj1.initInt(appearBuf->getLength()));
> Annot.cc:    appearDict.dictAdd("Subtype", obj1.initName("Form"));
> Annot.cc:    appearDict.dictAdd("BBox", &obj1);
> 
> They all add an entry to the dictionary using a constant key.
> However, in Dict.cc:34 we have gfree(entries[i].key) which is obviously
> problematic.
> 
> An easy solution would be to use something like gstrdup(). I'm not sure
> what the right solution is.

Looks like the right thing to do is copyString("blah").

-Jeff