[poppler] Annot Improving (III)

[Iñigo Martínez]

Hi:

I have changed again the last patch with the required changes and synced
it with the git head.

I have tried it with some annot testing PDF documents I have around and
everything looks like is working correctly, but I have some (more)
things I have notes about thought.

1. When the dash numbers in the arrays are wrong, poppler old code does
give them 1 value, but reading the pdf reference there is this:

"Note that no dash phase is specified; the phase is assumed to be 0."

So I have assumed that it should have 0, so I have changed it. There are
some error handling I don't know have to handle too, so I have added a
TODO comment to do it later.

2. When handling the colors, poppler old code does default red and green
to 0 but blue to 1. There is nothing about that in the reference. My
code does default all colors to 0, as it does support more color spaces,
maybe I shoudl change it but, where are those 'magic' numbers come
from ?

I think I should do some testing with Acrobat Reader to test everything.
How do you do those testings ? How do you know what values does use
Acrobat once it detects a wrong object/value ?

As always any comment is welcome.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler-071206.diff
Type: text/x-patch
Size: 28423 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20071206/42f47045/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20071206/42f47045/attachment-0001.pgp